Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: basic textobjects #109

Closed
wants to merge 1 commit into from
Closed

Conversation

tonyjthomas
Copy link

Implements a non-exhaustive set of textobjects, most importantly @function.inner and @function.outer.

First time writing treesitter queries, so please let me know if anything can be improved. Hopefully this is a reasonable starting point that others can add to.

@Nsidorenco
Copy link
Member

Hi @tonyjthomas,
Thank you for taking your time creating this!

I am not quite sure if I think this is the best place for these queries, since they are uniquely tailored to a Neovim plugin.
Since the tree-sitter parser is editor-agnostic I think it is best to keep the queries to the set of standard captures.

It looks like languages that nvim-treesitter-textobjects support have their queries defined in the nvim-treesitter-textobjects repo itself so I think it would be best to contribute these queries there.

@tonyjthomas
Copy link
Author

Understood, I'll see about opening a PR there instead. Thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants